hiero-ledger / hiero-ledger/hiero-consensus-node

Harden calculateFees() and remove pureChecks() call from ingest workflow

Open
#13,680 1 comment 0 reactions 1 assignee Claimed by @joshmarinacci View on GitHub
Backlog Grooming Epic
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

We need to revisit all implementations of `TransactionHandler.calculateFees()` and ensure they handle invalid input data correctly. We decided that we will simply fail fast for now, if an error occurs while calculating the fees, i.e. we throw a `PreCheckException`.

Once all handers have been checked, we can remove the `pureChecks()` call from the ingest workflow.

- [x] Harden `calculateFees()` in AddressbookService
- [ ] Harden `calculateFees()` in ConsensusService
- [ ] Harden `calculateFees()` in FileService
- [ ] Harden `calculateFees()` in NetworkAdminService
- [ ] Harden `calculateFees()` in ScheduleService
- [x] #13681
- [ ] Harden `calculateFees()` in TokenService
- [ ] Harden `calculateFees()` in UtilService
- [ ] Remove `pureChecks()`-call from ingest workflow

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.