hiero-ledger / hiero-ledger/hiero-consensus-node

Update Contributing Guidelines

Open
#10,102 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
406
Forks
226
Avg merge
3d 4h
Merged PRs (30d)
210

Description

### Problem

When creating new Pull requests I've noticed that people are guided to branch off the `main` branch.
"
4. Sync your local `main` branch.

```sh
$ git pull upstream main
```

> **_Note_** Some repositories may still be using `master` for their default branch.

5. Create a branch to add a new feature or fix issues.

```sh
$ git checkout -b new-feature
```
"

This is not really precise. As I can see everyone starts from develop and is creating PR to develop as well (https://github.com/hashgraph/hedera-services/pulls?q=is%3Apr+is%3Aclosed).

### Solution

Create new file `CONTRIBUTING.md` inside the hedera-services repository, where starting branch will be stated explicitly.

### Alternatives

...or we can ignore it, but this intruduces unneccessary confusion among new contrubutors

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.