hfleitas / hfleitas/SentimentPrediction

Security, Trust_worthy, Unsafe Assembly not Supported in Linux, Support case-sensitive envs, Loopback connection

Open
#1 0 comments 0 reactions 1 assignee Claimed by @hfleitas View on GitHub
enhancement good first issue
Dominant language
Jupyter Notebook
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Few comments from @uc-msft

1. You are doing many settings like granting sysadmin role to SQLRUsergroup or execute permissions and so on which is not good security practice. It is also not required.

2. Same way, please put a note about TRUST_WORTHY bit in the sample - this is a huge security hole and we don't recommend doing this.

3. Instead create login from cert/assembly and use that for the unsafe assembly (for sp_rxpredict).

4. UNSAFE assembly is also not supported on Linux so I would probably caveat this part of the sample or not use the proc at all.

5. In the trollhunters notebook, there is some wrong casing of object names which breaks on case-sensitive environments.

6. For the loopback connection, construct the connection string using @@SERVERNAME & DB_NAME() - don't hard code localhost like that (it will not work with named instances, Linux or SQLDB). We actually added a helper function too in the our packages.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.