heroku / heroku/react-refetch

undefined value in connect function causes silent failure

Open
#129 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
3.4k
Forks
137
PR merge metrics
No merged PRs in 30d

Description

I had a bug where my `connect` function was returning something like `{"propName": undefined}`. When that happened, React just silently failed to render the whole component tree. There were no errors in the console, it just acted like I never called `ReactDOM.render()` on the top-level component.

Would it be possible to show an error in that circumstance? I'm not sure if this is a problem with your library or with React, but it took a while to hunt down the issue. I'm on React 15.1.0 and Chrome 51 if that helps.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.