heroku / heroku/platform-api

Bug/feature: Rate-throttling logic is global and not per-token

Open
#112 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
216
Forks
85
PR merge metrics
No merged PRs in 30d

Description

When I added the rate-throttle logic I did so on the assumption that the process would be making requests on behalf of a single token. I think this is still the most common case, but I didn't account for the scenario where one process might make many requests using many different tokens (think if you've written some kind of a proxy service and operates on each individual token).

The way to move forward is to make the RateThrottleClient instance local to each instance of `PlatformAPI`. This will require work in Heroics since that's what we hook into to provide this feature.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.