heroku / heroku/languages-github-actions

Remove branch input workarounds now that `job_workflow_sha` works properly

Open Beginner friendly
#371 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
4
Forks
2
Avg merge
12h 44m
Merged PRs (30d)
6

Description

Until recently the `github.job_workflow_sha` value wasn't set correctly in jobs that use a reusable workflow:
- https://github.com/actions/runner/issues/2417

This meant we had to add some workarounds in the actions in this repo:
https://github.com/heroku/languages-github-actions/blob/2652b059e05ccafc7c747973813d8bc6d6b1bc5c/.github/actions/install-languages-cli/action.yml#L5-L12

See also:
https://github.com/heroku/languages-github-actions/issues/106#issuecomment-1673238113

Now that `job_workflow_sha` is fixed, we should switch to that and remove the workarounds :-)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with .github/actions/install-languages-cli/action.yml, especially lines 5–12, and review the related workaround context in issue #106. Check the repository’s actions for similar branch-input workarounds, then switch them to github.job_workflow_sha and remove the obsolete inputs; done means the actions no longer need the workaround while continuing to work with reusable workflows.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.