heroku / heroku/languages-github-actions

Better messaging when buildpack is missing a changelog

Open
#182 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4
Forks
2
Avg merge
12h 44m
Merged PRs (30d)
6

Description

When a buildpack has no changelog, the prepare release action fails with a message like this:

```
❌ No buildpacks found under /home/runner/work/buildpacks-go/buildpacks-go
```

This is likely do to this line, which filters out valid buildpack directories that don't have a changelog:

https://github.com/heroku/languages-github-actions/blob/984b5bc4ab5e3296a19da19ffd1654d5afeaba52/src/buildpacks.rs#L55

Maybe instead of filtering here, we could raise a different error, and then provide a message more like:

```
❌ Buildpack in /home/runner/work/buildpacks-go/buildpacks-go/ does not include a CHANGELOG.md
```

This issue is also discussed here: https://github.com/heroku/buildpacks-go/pull/205.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.