heroku / heroku/heroku-buildpack-nodejs

Follow-up to devDependencies change

Open
#524 0 comments 0 reactions 0 assignees View on GitHub
needs investigation
Dominant language
Shell
Stars
1.3k
Forks
2.6k
Avg merge
1d 13h
Merged PRs (30d)
30

Description

From @edmorley:

- Does `warn_missing_devdeps` in failure.sh need updating to also check for `YARN_PRODUCTION`?
- Can the `NPM_CONFIG_PRODUCTION` export now be removed from `bin/test-compile`?
- In `environment.sh`'s `list_node_config`, should the `mcount "npm-config-production-true"` also include `YARN_PRODUCTION` (or a new count be added)?

Contributor guide

Open the contributing guide

Research direction

Start by reviewing failure.sh's warn_missing_devdeps, bin/test-compile, and environment.sh's list_node_config, tracing how NPM_CONFIG_PRODUCTION and YARN_PRODUCTION are handled. Determine the intended updates for the missing-dependency check, export, and metric, then verify that the related configuration behavior is consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, shell
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.