heroku / heroku/buildpacks-ruby

Remove byte-unit dependency in commons public interface

Open
#282 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
30
Forks
7
Avg merge
1d 17h
Merged PRs (30d)
5

Description

We cannot upgrade this dependency until errors are fixed https://github.com/heroku/buildpacks-ruby/pull/252. We should remove it from the interface entirely.

I'm not 100% sure how to gently do this. In ruby I would accept two different input types for awhile and at runtime issue a deprecation warning. I guess in Rust I just remove/change the type and let the compiler fail, maybe rev a breaking change version on commons.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.