henomis / henomis/quickchart-go

Key is being used in place of Version when creating a URL

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
11
Forks
1
PR merge metrics
No merged PRs in 30d

Description

https://github.com/henomis/quickchart-go/blob/7eed6dd90c19210e5d2e5bb7fa1f1f39ad6378d7/quickchart-go.go#L71

`qc.Version` isn't being used when creating a url for a chart. Looks like `qc.Key` was mistakenly used when setting the version. I've verified locally that I need to set `qc.Key` and `qc.Version` as the version I want in order to set the version, which doesn't seem like the expected/desired behavior.

Let me know if you'd like for me to PR. Looks like a tiny fix though.

Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.