helpfulengineering / helpfulengineering/project-data-platform-ts

Supply-tree page heading never renders (non-reactive var instead of ref)

Open Beginner friendly
#108 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vue
Stars
1
Forks
1
Avg merge
58m
Merged PRs (30d)
1

Description

What's happening

packages/front-end/pages/products/[id]/supplyTree.vue:26 declares:

var selectedOKHname : string;

as a plain, non-reactive module/setup-scope variable — not a Vue ref. It's assigned inside sendToSupplyGraphAI (line 53: selectedOKHname = selectedOkh.value.name;) and rendered in the template at line 159: <h1>{{ selectedOKHname }}</h1>.

Because it's a plain var, Vue's reactivity system never picks up the assignment, so the <h1> renders whatever selectedOKHname was at the component's first render (undefined/empty) and never updates, no matter how long the match request takes or what it returns.

Impact

The supply-tree page's heading is permanently blank — regardless of whether the OHM match call succeeds, fails, or is still loading.

Evidence

Confirmed via a standalone diagnostic script that clicked through to the page and waited well past any fetch/render delay — the heading stayed empty. Captured as the expected current behavior (not "fixed" to look correct) in packages/e2e/tests/main-workflow.spec.ts.

Likely fix

Change var selectedOKHname : string; to const selectedOKHname = ref<string>(""); (or fold it into the existing selectedOkh ref) and update the template binding to {{ selectedOKHname }}{{ selectedOKHname.value }} is not needed in <template> (auto-unwrapped), just switch the declaration and the one assignment site to .value.

Tracked as a known issue in dev-docs/TESTING.md / AGENT.md.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in packages/front-end/pages/products/[id]/supplyTree.vue at the declaration on line 26, the assignment in sendToSupplyGraphAI on line 53, and the heading around line 159. Review packages/e2e/tests/main-workflow.spec.ts for the current behavior, then run that test. Done means the supply-tree heading displays the selected OHM name after the match request completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.