helm / helm/helm-mapkubeapis

Not all apis removed from release

Open
#110 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
1k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

Hello.
We are using helm v3.7.2 + mapkubeapis v0.4.1
k8s node v1.24.9 (where old release version deployed) and v1.25.6 (where plugin executed)

On some releases plugin removes all removed apis, but one of this has removed only 4 of 5 `apiVersion: policy/v1beta1\nkind: PodSecurityPolicy\n`

There are logs of that execution:
```
/tmp $ helm-v3.7.2 mapkubeapis project-monitoring --namespace project
2023/04/04 21:09:34 Release 'project-monitoring' will be checked for deprecated or removed Kubernetes APIs and will be updated if necessary to supported API versions.
2023/04/04 21:09:34 Get release 'project-monitoring' latest version.
2023/04/04 21:09:34 Check release 'project-monitoring' for deprecated or removed APIs...
2023/04/04 21:09:34 Found 4 instances of deprecated or removed Kubernetes API:
"apiVersion: policy/v1beta1
kind: PodSecurityPolicy
"
No supported API equivalent
2023/04/04 21:09:34 Finished checking release 'project-monitoring' for deprecated or removed APIs.
2023/04/04 21:09:34 Deprecated or removed APIs exist, updating release: project-monitoring.
2023/04/04 21:09:34 Set status of release version 'project-monitoring.v1' to 'superseded'.
2023/04/04 21:09:35 Release version 'project-monitoring.v1' updated successfully.
2023/04/04 21:09:35 Add release version 'project-monitoring.v2' with updated supported APIs.
2023/04/04 21:09:35 Release version 'project-monitoring.v2' added successfully.
2023/04/04 21:09:35 Release 'project-monitoring' with deprecated or removed APIs updated successfully to new version.
2023/04/04 21:09:35 Map of release 'project-monitoring' deprecated or removed APIs to supported versions, completed successfully.
```

I used the following command to get secret manifests:
`kubectl get secret -n project sh.helm.release.v1.project-monitoring.v1 --template={{.data.release}} | base64 -d | base64 -d | gzip -d | jq -r .manifest > before.json`

Please find [before.yaml](https://github.com/helm/helm-mapkubeapis/files/11153682/before.yaml.txt) and [after.yaml](https://github.com/helm/helm-mapkubeapis/files/11153681/after.yaml.txt) attached. I left only the beginning of the files where there are differents

May be it will useful information: release where plugin removed all three 'wrong' apis has exported secret size 71kb, but release where removed 4 of 5 has exported secret size 477kb and 3.2mb of decoded unzipped manifest field.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.