helm / helm/helm-mapkubeapis

Update/create timing window

Open
#10 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
1k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

There is a problem with this plugin as it depends on two successful etcd backed operations to correctly map a release (update, create). If the process dies after the old release is updated to `StatusSuperseded `[1] but before creating the new revision[2], this release is toast as there aren't any `Deployed` revisions. This can also happen if etcd is having problems and the `cfg.Releases.Create` call fails.

I wonder if this command could be updated to check for a release with no `Deployed` revisions and handle accordingly? That would solve both cases without having too much special case handling.

[1] https://github.com/hickeyma/helm-mapkubeapis/blob/master/pkg/v3/release.go#L67
[2] https://github.com/hickeyma/helm-mapkubeapis/blob/master/pkg/v3/release.go#L82

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.