helm / helm/chartmuseum

"Application metrics" not being exported after setting ENABLE_METRICS

Open
#713 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
3.8k
Forks
407
PR merge metrics
No merged PRs in 30d

Description

Chart version: 3.6.2

We've set ENABLE_METRICS:

```
/ $ strings /proc/1/environ | grep -i metrics
ENABLE_METRICS=true
```

...however, the metrics `chartmuseum_charts_served_total` and `chartmuseum_chart_versions_served_total` documented [here](https://github.com/helm/chartmuseum#prometheus-metrics) aren't being exported.

```
❯ curl -s localhost:8080/metrics | grep -v "#" | grep chartmuseum_chart | wc -l
0
```

The "general global metrics" are being exported:

```
❯ curl -s localhost:8080/metrics | grep -v "#" | grep -i chartmuseum
chartmuseum_request_duration_seconds_sum 11.347815388000111
chartmuseum_request_duration_seconds_count 330745
chartmuseum_request_size_bytes_sum 2.8782004e+07
chartmuseum_request_size_bytes_count 330745
chartmuseum_requests_total{code="200",handler="helm.sh/chartmuseum/pkg/chartmuseum/router.(*Router).rootHandler-fm",host="x:8080",method="GET",url="/health"} 330192
chartmuseum_requests_total{code="200",handler="helm.sh/chartmuseum/pkg/chartmuseum/router.(*Router).rootHandler-fm",host="x:8080",method="GET",url="/:repoindex.yaml"} 553
chartmuseum_response_size_bytes_sum 4.34963519e+08
chartmuseum_response_size_bytes_count 330745
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with ChartMuseum 3.6.2 and ENABLE_METRICS=true, then query localhost:8080/metrics and compare the output with the documented chartmuseum_charts_served_total and chartmuseum_chart_versions_served_total metrics. Done means those application metrics are exported alongside the existing general global metrics.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.