helm / helm/chartmuseum

Changes to chart-url do not affect the index-cache file

Open
#378 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
3.8k
Forks
407
PR merge metrics
No merged PRs in 30d

Description

Similar to https://github.com/helm/chartmuseum/issues/157 (or pretty much the same).

The current behavior of the `--chart-url` is very confusing. If it is set, all packages in the `index.yaml` have absolute url in their name, and that behavior is absolutely correct.

However, if that variable is changed (let's say you have decided to migrate your chart museum to another domain), old values are not affected, so potentially you will be serving URLs that point to non-existing domains.

If a new package is uploaded, then it would be stored with a new url, but all other packages will maintain the old one.

What we can potentially do, is (if the chart-url is enabled) to scan the index-cache.yaml file, and as long as there is at least one package with a wrong prefix (!= chat-url), then force regeneration if the cache file.

Such operation could be performed on the application startup (however I am not sure about possible concurrency issue).

I can pick this task, as long as we come to an agreement about the path to take.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.