helm / helm/chartmuseum

--depth-dynamic boolean flag does not work

Open
#337 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
3.8k
Forks
407
PR merge metrics
No merged PRs in 30d

Description

https://github.com/helm/chartmuseum/pull/232 is supposed to enable this config variable. However, by reading the code and also running in the debug mode, I suspect that it does not really do what we might expect. The changes in the match() function in match.go file for this feature don't seem to do anything. Under the debug mode, the logic in the match() is confusing.
I can't find any design document or user document for this feature. If someone can point me to any document how it is designed, I can look at this feature and see if there is any change to enable this feature correctly.
Just to give you an example I tried in the debug mode. I used depth = 2 and depth-dynamic=true. Then I curl the http://locahost:8080/api/org1/repo1/charts.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.