hedge-dev / hedge-dev/UnleashedRecomp

MSAA Affects the Water Distortion Shader when it shouldn't

Open
#1,521 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

original game bug
Dominant language
C++
Stars
5.1k
Forks
421
PR merge metrics
No merged PRs in 30d

Description

Validation
  • I have checked the Issues page to see if my problem has already been reported
  • I have confirmed that this bug does not occur in the original game running on original Xbox 360 hardware
If you have DLC installed, please specify which ones you have.
  • Apotos & Shamar Adventure Pack
  • Chun-nan Adventure Pack
  • Empire City & Adabat Adventure Pack
  • Holoska Adventure Pack
  • Mazuri Adventure Pack
  • Spagonia Adventure Pack
If you have mods enabled, please specify which ones you have.

Optional Improvements
Refined Sonic Controls
Generic QTE Buttons

If you have codes enabled, please specify which ones you have.

All Fixes, (Unleash out of Control Drain, Eggmanland event gallery transition)
Allow Unleash Cancel
Save Score at Checkpoints
Use Official Title on Title Bar
Disable Auto Save Warning and DLC Icon
Toggle UI with F8

Describe the Bug

It Seems as though MSAA interacts with the water when it shouldn't.

Image

Steps to Reproduce
  1. Enable MSAA
  2. Go to any level with water
  3. Position the camera so an object is rendered above of the water
Expected Behavior

Water Shader isn't affected by MSAA

Image

Footage

It might not show up well, it is very subtle

https://github.com/user-attachments/assets/e28069ad-ba28-4526-904f-372375238fa9

System Specifications

Renderer: Vulkan (Might Matter, not sure)
CPU: i3 4160
GPU: r9 280 3GB (1150 MHz OC)
GPU Driver: Radeon 22.6.1 (Latest)
OS: Windows 10 22H2
Version: 1.0.3

Additional Context

I am unable to test DirectX 12 as my GPU doesn't support Shader Model 6.0 or full DX12 (11.1)

Video Settings (Probably Doesn't Matter):

AspectRatio = "16:9"
ResolutionScale = 1
Fullscreen = true
VSync = false
TripleBuffering = "Auto"
FPS = 241
ShowFPS = true
MaxFrameLatency = 2
Brightness = 0.29999998
AntiAliasing =  Both 8x MSAA and None
TransparencyAntiAliasing = false
AnisotropicFiltering = 16
ShadowResolution = "4096"
GITextureFiltering = "Bicubic"
DepthOfFieldQuality = "Auto"
MotionBlur = "Off"
XboxColorCorrection = false
CutsceneAspectRatio = "Unlocked"
UIAlignmentMode = "Edge"

[Update]
LastChecked = 1743811810

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Vulkan renderer by enabling and disabling MSAA, then visit a level with water and position the camera as described. Compare the water distortion with an object rendered above the water. Done means MSAA no longer changes the water shader's appearance, while the existing reproduction steps no longer show the artifact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.