hedge-dev / hedge-dev/UnleashedRecomp

Music Attenuation does not affect cutscenes

Open
#1,351 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

audio option
Dominant language
C++
Stars
5.1k
Forks
421
PR merge metrics
No merged PRs in 30d

Description

While the in-game music slider not affecting cut-scenes is consistent with the original game's behaviour, I used to regularly play with a custom soundtrack back in the day and can confirm with certaincy that in the original Xbox 360 version, the music attenuation feature that activated when playing music using the 360's media player DID affect all non-FMV cut-scenes, muting the cut-scene music just the same as it did gameplay music (FMV cut-scenes would instead pause the 360 media playback until they ended, which naturally is probably beyond the scope for this PC version to affect other apps like that). On recompiled, this is not so, cut-scene music plays even when music attenuation is active.

Hopefully the desire to not have cut-scene music play can be met with a mod anyway and so this might not be considered worthwhile to look into for that reason; but if the goal for the project is to match the original game's behaviour in all ways that aren't negative to the experience, this would be a small inconsistency/downgrade to that end, slightly hampering the benefits of the music attenuation feature.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the music attenuation logic and the audio paths used by non-FMV cutscenes, then trace how the feature currently distinguishes gameplay from cutscene music. Done means attenuation also mutes non-FMV cutscene music while leaving FMV behavior unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.