hedge-dev / hedge-dev/UnleashedRecomp
GitHub Action doesn't respect Pull Requests and it's branches while validating.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 5.1k
- Forks
- 421
- PR merge metrics
- No merged PRs in 30d
Description
It appears that GitHub Action on the .yml validate doesn't include something like this:
on:
pull_request:
branches:
- main
types:
- edited
- opened
- synchronize
While it's fine for releases, Git Actions will instead use main as opposed to using the pull request's changes for testing purposes.
This caused several hours of troubleshooting when trying to test the changes before merging to Master. Had to resort to building the file myself due to it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the validation .yml GitHub Actions workflow and its current trigger and checkout configuration. Test the workflow from a pull request targeting main, then confirm that validation runs against the pull request's changes rather than the main branch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100