hedge-dev / hedge-dev/UnleashedRecomp
PlayStation Lightbar/LED Events doesn't function if Single or Multiple controllers are connected or reconnected.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 5.1k
- Forks
- 421
- PR merge metrics
- No merged PRs in 30d
Description
Validation
- I have checked the Issues page to see if my problem has already been reported
- I have confirmed that this bug does not occur in the original game running on original Xbox 360 hardware
If you have DLC installed, please specify which ones you have.
- Apotos & Shamar Adventure Pack
- Chun-nan Adventure Pack
- Empire City & Adabat Adventure Pack
- Holoska Adventure Pack
- Mazuri Adventure Pack
- Spagonia Adventure Pack
If you have mods enabled, please specify which ones you have.
n/a
If you have codes enabled, please specify which ones you have.
n/a
Describe the Bug
This is somewhat related to https://github.com/hedge-dev/UnleashedRecomp/issues/409, but this time: Controller Hotswapping.
If one or multiple controllers are reconnected after an in-game lightbar event has occurred, it'll override the in-game lightbar to a Player Slot color/colours. It'll revert back when the next in-game event activates.
I...believe this is due to the lack of a fallback if the Controller's lightbar, which fails to listen to the current in-game event. That's in addition of the no daytime variant of SetControllerTimeOfDayLED's isNight function.
This is something I've been trying to fix myself as part of https://github.com/hedge-dev/UnleashedRecomp/pull/1188.
Steps to Reproduce
First things first, grab at least two PlayStation controllers that has Lightbar functionality that can change colors/colours. A DualShock 4 and/or DualSense will make do.
- After game launch, plug both controllers onto your device. (alternatively: a single controller, but two controllers are ideal to better troubleshoot)
- Enter to the Night stage.
- Reconnect the controller (or reconnect if you're doing it via Bluetooth mode)
- pay attention to the lightbar
Expected Behavior
I expect the controller's lightbar to stay within the same color event when swaping or reconnecting controllers, as opposed to the next in-game lightbar event.
Footage
https://github.com/user-attachments/assets/9048f364-5744-4263-8505-27e3a69ae552
https://github.com/user-attachments/assets/be8aa119-00e7-4c5a-94de-a4cd77c2568b
Specifications
Fill out the following details:
- CPU: AMD Ryzen 9 5900HS with Radeon Graphics
- GPU: NVIDIA GeForce RTX 3070
- GPU Driver: NVIDIA Driver 572.70
- OS: Windows 11 24H2
- Version: 1.0.2
Additional Context
n/a
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the controller lightbar event handling, with particular attention to SetControllerTimeOfDayLED and the related issue #409. Compare the behavior when controllers are connected or reconnected during a Night stage event, and review pull request #1188 for the attempted fix. Done means reconnecting controllers preserves the current in-game lightbar event instead of reverting to player-slot colors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100