heatherleaf / heatherleaf/korpsearch

Filter search results using regex queries

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2
Forks
6
PR merge metrics
No merged PRs in 30d

Description

For complicated queries that the indexes can't handle, we should filter the results in the end. Here's the line doing that:

https://github.com/heatherleaf/korpsearch/blob/077dd16bb913d17ed65da3d1927785e73450c98d/search.py#L220

But if the literal is a regex, then the check_position method will check with the expanded literal (which can be a disjunction of 1000s of tokens), and not with the original regex.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at search.py line 220 and trace how check_position receives the expanded literal for regex queries. Compare that path with the original regex handling and add coverage for a regex that expands into many tokens; done means final filtering uses the intended regex semantics rather than only the expanded literal.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.