hcengineering / hcengineering/huly-selfhost

Love Service needs to be accessible from outside of the docker internal network

Open
#89 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
3.5k
Forks
469
PR merge metrics
No merged PRs in 30d

Description

The Love Server mentioned in the [README](https://github.com/hcengineering/huly-selfhost?tab=readme-ov-file#love-service-audio--video-calls) needs to be remotely accessible it seems.

Therefore simply passing the docker internal domain and port wont work as the browser will try to reach the domain which is unaccessible.

Therefore it should be declared inside the docker compose similar to the other remotely accessible services:
LOVE_ENDPOINT=${NGINX_HTTP_SCHEME}://${SERVER_ADDRESS}/_love

And there should also be a nginx rule supporting this similar to:

location /_love{
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;

rewrite ^/_accounts(/.*)$ $1 break;
proxy_pass http://love:8096/;
}

^^

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.