hcengineering / hcengineering/huly-selfhost

Github OAuth x Github Integration - Confusion around Environment Variables

Open
#296 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
3.5k
Forks
469
PR merge metrics
No merged PRs in 30d

Description

Hi all,

Another quick question. I'll answer it myself after some tinkering, if I find a solution.

The environment variables defined for the `front` container are:

`GITHUB_CLIENT_ID`
`GITHUB_CLIENT_SECRET`

Meanwhile, the environment variables defined for the `github` container are:

`GITHUB_CLIENTID`
`GITHUB_CLIENT_SECRET`

Given that "OAuth Apps" and other "Apps" in Github are treated separately, I assume that these refer to two different apps. Therefore, it makes sense to keep the variables named separately and not overlapping as they do with `GITHUB_CLIENT_SECRET`. I've renamed them appropriately in my .env file and have adjusted the compose.yml file to handle the new names. Now, let's see if it works, I'll post updates here :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.