hbb20 / hbb20/CountryCodePickerProject

IndexOutOfBoundsException in getSectionTitle of CountryCodeAdapter

Open
#619 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.5k
Forks
509
PR merge metrics
No merged PRs in 30d

Description

```
Fatal Exception: java.lang.IndexOutOfBoundsException
Index: 253, Size: 253
java.util.ArrayList.get (ArrayList.java:437)
com.hbb20.CountryCodeAdapter.getSectionTitle (CountryCodeAdapter.java:1)
```

Sometimes `FastScroller.java` crashes app. It will be better to check the length of `filteredCountries` before get `CCPCountry` in this line

`CCPCountry ccpCountry = filteredCountries.get(position);` (202 line of `CountryCodeAdapter` class)

For example like this:

```
public String getSectionTitle(int position) {
if (preferredCountriesCount > position) {
return "★";
} else if (filteredCountries.size() > position) {
return filteredCountries.get(position).getName().substring(0, 1);
} else {
return ""; //this should never be the case but it does
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.