hbashton / hbashton/DS4Windows
Virtual controller created by ShadowPC not recognized
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 272
- Forks
- 10
- Avg merge
- 13d 5h
- Merged PRs (30d)
- 1
Description
Describe the bug
Before when enabling the virtual controller support, the virtual controller created by ShadowPC was correctly recognized. However, in this fork a specific Sunshine check has been hardcoded in. This means virtual controllers are only recognized when a Sunshine process is running.
To Reproduce
Steps to reproduce the behavior:
- Enabled virtual (Sunshine) controller support
- Make sure Sunshine is not running
- Connect virtual controller
- Virtual controller is not recognized
Expected behavior
Virtual controllers should be recognized, even when there's no Sunshine process present. Maybe this could be added as an additional option to also preserve the current behavior
Workaround
Install and start Sunshine (even though this is not used for the actual game streaming in this case). The IsSunshineHostRunning() check will then pass, allowing the virtual controller to be recognized.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the hardcoded IsSunshineHostRunning() check into the virtual controller recognition path. Reproduce the issue with Sunshine stopped, then verify that the ShadowPC virtual controller is recognized without Sunshine while the existing behavior remains available if intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100