hazelcast / hazelcast/hazelcast-nodejs-client

Fail test suite on unhandled promise rejection [API-1604]

Open
#636 4 comments 0 reactions 0 assignees View on GitHub
Priority: Low to-jira Type: Enhancement
Dominant language
TypeScript
Stars
152
Forks
64
Avg merge
46m
Merged PRs (30d)
3

Description

In the past I faced several places where we weren't handling promise rejections properly. In future version of node, it's very likely that it will start throwing on unhandled promise rejections, so, we need to make sure that there are no such places in the library code base, as well as in the test suite. The proper way should be to log details of the rejection and stop the [process](https://nodejs.org/api/process.html#process_event_uncaughtexception) with an error code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.