hazelcast / hazelcast/hazelcast-nodejs-client
[TRACKING ISSUE] Disallow different types of generic records in GenericRecordBuilder.setGenericRecord API-1773
- Dominant language
- TypeScript
- Stars
- 152
- Forks
- 64
- Avg merge
- 46m
- Merged PRs (30d)
- 3
Description
The tracking issue for the Java side PR.
See https://github.com/hazelcast/hazelcast/pull/23522 for details.
---
Right now, GenericRecordBuilder.setGenericRecord does not throw if the value is not of the same type of generic record. (compact for compact, portable for portable)
We instead throw a cast exception while trying to do toData. We should do it during the setter.
Breaking changes (list specific methods/types/messages):
* If some users were misusing the API, they may be affected
Checklist:
- [x] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set
- [x] Label `Add to Release Notes` or `Not Release Notes content` set
- [x] Request reviewers if possible
- [x] Send backports/forwardports if fix needs to be applied to past/future releases
- [x] New public APIs have `@Nonnull/@Nullable` annotations
- [x] New public APIs have `@since` tags in Javadoc
I don't think we need backports for this change.
Contributor guide
Assessment
This issue has not been assessed yet.