hazelcast / hazelcast/hazelcast-nodejs-client
Comparator's `sort` might be unnecessary
Open
Breaking Change
Estimation: S
Source: Internal
to-jira
Type: Defect
- Dominant language
- TypeScript
- Stars
- 152
- Forks
- 64
- Avg merge
- 46m
- Merged PRs (30d)
- 3
Description
Originally reported by @puzpuzpuz
**Describe the bug**
`sort` method in the TS `Comparator` interface used by `PagingPredicate` seems to be redundant. The client doesn't need it since the sort happens on member side
**Expected behavior**
get rid of it if it's really redundant/or maybe deprecate it
**Additional Info**
https://github.com/hazelcast/hazelcast-nodejs-client/blob/610eebce388f76ee1313d66b107612b3aba720b6/src/core/Comparator.ts#L36
https://github.com/hazelcast/hazelcast-python-client/blob/d63e83d3379633bf310e52ae3c0bc8b226460b22/examples/map/map_paging_predicate_example.py#L45
Contributor guide
Assessment
This issue has not been assessed yet.