hazelcast / hazelcast/hazelcast-csharp-client

[TRACKING ISSUE] Refactoring client deregister listener behaviour [API-2081]

Open
#398 2 comments 0 reactions 0 assignees View on GitHub
Jira Source: Tracking
Dominant language
C#
Stars
107
Forks
52
PR merge metrics
No merged PRs in 30d

Description

The tracking issue for the Java side PR.

**Refactoring client deregister listener behaviour**

See https://github.com/hazelcast/hazelcast/pull/17646 for details.

---

We were returning `false` as the return value if we were not
successuflly deregister from any member and events was able to
continue to delivered for non deregistered members.

We have changed the behaviour so that we return `true` if a
registration is found always. And after this point, user will not
get any event. We will cleanup all the local handlers right away
to make sure of that.

Secondly we have set invocation timeout as infinite so that the
deregistartion from a connection is retried as long as the
connection is there until it is succesful.

I have left logging the exception when there is an unexpected
failure. We do not expect any but this is to be able to diagnose
if the unexpected happens.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.