hazelcast / hazelcast/hazelcast-cpp-client

[TRACKING ISSUE] Register class definitions and check compatibility of nested portable…

Open
#817 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
91
Forks
54
Avg merge
1d 12m
Merged PRs (30d)
5

Description

The tracking issue for the Java side PR.

See https://github.com/hazelcast/hazelcast/pull/18180 for details.

---

… fields of generic records

We were registering the class definition of the parent generic record
and checking the class definition compatibility if the `checkClassDefErrors`
set to true on the serialization config.

But we were not doing it for the nested portable fields
(for child portables and elements of portable arrays). Now, we are checking them too.

Also, on the class definition registration, we were checking the class definition
compatibility again, without looking at the `checkClassDefErrors` property. Responsibility
of the class definition comptaibility check is moved to the registration and it is
refactored such that it will not throw if a boolean flag is set to false.

Also, an unnecessary factory id check (since the portable context is created for the
factory id of the class definition, hence, it cannot be different) and unnecessary
second put to the registration map is removed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.