hazelcast / hazelcast/hazelcast-cpp-client

[TRACKING ISSUE] Improve connection close logic in HeartbeatManager

Open
#786 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
91
Forks
54
Avg merge
1d 12m
Merged PRs (30d)
5

Description

The tracking issue for the Java side PR.

**Improve connection close logic in HeartbeatManager**

See https://github.com/hazelcast/hazelcast/pull/17578 for details.

---

* `HeartbeatManager#checkConnection` could try to send ping message over a connection which it closed in `#onHeartbeatStopped` method. This PR fixes the logic by adding an early `return`
* Also gets rid of redundant `connection.isAlive()` check

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.