hazelcast / hazelcast/hazelcast-code-samples

Remove dependencies on old versions

Open
#420 3 comments 2 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
558
Forks
600
PR merge metrics
No merged PRs in 30d

Description

We have many samples that work either directly or transitively with old Hazelcast versions. It leads to runtime problems (CNFEs for instance).

The following check was done for Hazelcast [tag v4.0.1](https://github.com/hazelcast/hazelcast-code-samples/tree/v4.0.1)

```bash
mvn dependency:tree -Dverbose -DoutputFile=/tmp/dependency.txt -DappendOutput=true

egrep ':hazelcast-all:jar|:hazelcast:jar|:hazelcast-enterprise:jar|:hazelcast-enterprise-all:jar' /tmp/dependency.txt |
grep -v 4\.0\.1 |
sed 's#^.*\(com.hazelcast.*:compile\).*#\1#' |
sort -u

com.hazelcast:hazelcast-all:jar:3.10.2:compile
com.hazelcast:hazelcast-all:jar:3.11.2:compile
com.hazelcast:hazelcast-all:jar:3.12.2:compile
com.hazelcast:hazelcast-all:jar:3.9.1:compile
com.hazelcast:hazelcast-all:jar:3.9:compile
com.hazelcast:hazelcast-enterprise:jar:3.11:compile
com.hazelcast:hazelcast:jar:3.10.2:compile
com.hazelcast:hazelcast:jar:3.11.4:compile
com.hazelcast:hazelcast:jar:3.11:compile
com.hazelcast:hazelcast:jar:3.12.2:compile
com.hazelcast:hazelcast:jar:3.12:compile
com.hazelcast:hazelcast:jar:3.7.5:compile
com.hazelcast:hazelcast:jar:3.7.7:compile
com.hazelcast:hazelcast:jar:3.7.8:compile
com.hazelcast:hazelcast:jar:3.7:compile
com.hazelcast:hazelcast:jar:3.9.1:compile
com.hazelcast:hazelcast:jar:3.9.3:compile
com.hazelcast:hazelcast:jar:3.9:compile
```

If we are not able to provide a code-sample with correct Hazelcast dependency, we should drop the sample from the related release (/tag).

We provide code samples archive as a separate download for every IMDG release, so it's a shame when the sample doesn't work with the given Hazelcast version.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.