haypho / haypho/smite

Remove use of deprecated 'Role' type

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue high priority
Dominant language
TypeScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Previously the 'Role' type was introduced as an `enum`, however, it has recently been deprecated in favor of using the `string` type. This way we can dynamically pull roles from the data on nightly deploys even though we have not updated the website to support those types.

- [ ] Remove the deprecated 'Role' type
- [ ] Convert the `RoleFilter` component to use a dynamic list of roles derived from the list of gods

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the deprecated Role definition and the RoleFilter component, then trace the list of gods used by the filter. Remove the enum-based type and make the filter derive its role options from that gods list; done means roles can change with nightly data without updating the website types.

Written by the indexing model from the issue text.

Assessment

Tech stack
next.js, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.