hasura / hasura/graphql-engine

server: allow `.` in event trigger names

Open
#9,429 0 comments 0 reactions 0 assignees View on GitHub
a/eventing/data-triggers k/enhancement
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

### Is your proposal related to a problem?

Event trigger names (used to construct SQL trigger name) can have `.`, but the server as well as the console prohibits this right now.

### Describe the solution you'd like

Allow using `.` in event trigger names by changing the regex to `^[A-Za-z]+[A-Za-z0-9_.\\-]*$`

### Describe alternatives you've considered

The alternative is to use the `replace_metadata` API to change the name of event trigger.

Contributor guide

Open the contributing guide

Research direction

Start by locating the event trigger name validation in the server and console, then find the related validation tests if present. Update the regex to accept periods while retaining the existing restrictions, and verify that event trigger names containing `.` are accepted in both places without allowing invalid names.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.