hasura / hasura/graphql-engine
Misspelling in hdb_catalog down migrations
- Dominant language
- TypeScript
- Stars
- 32.1k
- Forks
- 3k
- PR merge metrics
- PR metrics pending
Description
### Version Information
Server Version: 2.6.0
### Environment
OSS
### What is the expected behaviour?
Certain migrations include this snippet:
```sql
WHEN ((rt.typtype) :: text = ('p' :: character(1)) :: text) THEN 'PSUEDO' :: text
```
`PSUEDO` is a misspelling of `PSEUDO`
I am unsure what impact, if any, this could have.
Please note these are all down migrations and are rarely used, so it is possible there _is_ and impact but it has never been brought up.
### Keywords
sql hasura schema migrations misspelling.
### Can you identify the location in the source code where the problem exists?
This happens in the following files: [13_to_12.sql](https://github.com/hasura/graphql-engine/blob/master/server/src-rsr/migrations/13_to_12.sql#L36), [22_to_23.sql](https://github.com/hasura/graphql-engine/blob/master/server/src-rsr/migrations/22_to_21.sql#L39), [23_to_22.sql](https://github.com/hasura/graphql-engine/blob/master/server/src-rsr/migrations/23_to_22.sql#L147)
### If the bug is confirmed, would you be willing to submit a PR?
Happy to open a PR, but only once it becomes clear what the potential impact is.
Contributor guide
Research direction
Start by reviewing the down-migration snippets in server/src-rsr/migrations/13_to_12.sql, 22_to_21.sql, and 23_to_22.sql at the locations identified in the issue. Check the impact of the misspelled PostgreSQL type label in these migrations before making a consistent correction; done means the affected migrations use PSEUDO and remain valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100