hasura / hasura/graphql-engine

hasura doesn't forward set-cookie header from action when action is a query type

Open
#8,407 2 comments 6 reactions 0 assignees View on GitHub
k/bug team-blaam/handover
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

### Version Information

Server Version: 2.6.0-beta.1
CLI Version (for CLI related issue): 2.6.0-beta.1

### Environment

OSS

### What is the expected behaviour?

Hasura should forward `set-cookie` header regardless of whether the action is a `Query` or `Mutation`

### Keywords

action, set-cookie, header

### What is the current behaviour?

Currently hasura only seems to forward the `set-cookie` header only if the action is a `Mutation`

### How to reproduce the issue?

1. create a webhook that set's a cookie
2. create a `Query` action that references the above created webhook
3. see hasura is not forwarding the `set-cookie` header

### Screenshots or Screencast

### Please provide any traces or logs that could help here.

### Any possible solutions?

When the action is a `Mutation` hasura forwards the `set-cookie` header successfully

### Can you identify the location in the source code where the problem exists?

No

### If the bug is confirmed, would you be willing to submit a PR?

I don't know haskell

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with a webhook that sets a cookie, then compare a Query action with a Mutation action. Trace the action webhook response handling and add or update coverage so both action types forward the set-cookie header; done means the Query response matches the existing Mutation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, haskell
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.