hasura / hasura/graphql-engine

Partial error in remote schema should return partial result from remote schema.

Open
#8,259 1 comment 1 reaction 0 assignees View on GitHub
c/remote-schemas k/bug t/gql-services
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

### Version Information

Server Version: v2.2.0 vs v1.3.3
CLI Version (for CLI related issue):

### Environment
OSS

### What is the expected behaviour?
partial error in remote schema should return partial result from remote schema. that was working in the old version (v1.3.3) but not in newer version v2.2.0.

Sample code )
```
query:
item(key: $key) {
dt
something_good
something_wrong
}
```
expected response:
```
{
"errors": [
{
"message": "no field of name something_wrong",
"locations": [
{
"line": 5,
"column": 5
}
],
"path": [
"item",
"something_wrong"
]
}
],
"data": {
"item": {
"dt": [
"2022-02-26",
"2022-02-27",
"2022-02-28"
],
"something_good": [
1,
2,
3
],
"something_wrong": null
}
}
}
```

### Keywords
remote schema
error handling

### What is the current behaviour?

data field become null

actual response:
```
{
"errors": [
{
"message": "no field of name something_wrong",
"locations": [
{
"line": 5,
"column": 5
}
],
"path": [
"item",
"something_wrong"
]
}
],
"data": null
}
```

### How to reproduce the issue?

1. connect to remote schema with partial error

### Screenshots or Screencast

difficult to share the screenshot but I'm sure the sample code is clear enough

### Please provide any traces or logs that could help here.
difficult to share but I'm sure the sample code is clear enough

### Any possible solutions?

If you can give some workaround, that would be very helpful

### Can you identify the location in the source code where the problem exists?

### If the bug is confirmed, would you be willing to submit a PR?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.