hasura / hasura/graphql-engine
remote console tries to load server assets
- Dominant language
- TypeScript
- Stars
- 32.1k
- Forks
- 3k
- PR merge metrics
- PR metrics pending
Description
### Version Information
Server Version: v2.1.1
CLI Version (for CLI related issue): v2.1.1
### Environment
EE
### What is the expected behaviour?
running local console `hasura console --endpoint 'https://my.server'` should work against server that has console disabled.
### Keywords
remote console
### What is the current behaviour?
When running `hasura console --endpoint 'https://my.server'` local console tries to load static assets from my.server. As console is disabled it can't find assets. Looking the code seems `--use-server-assets` is false by default. Either way setting `--use-server-assets false` still results console trying to load assets from my.server
### How to reproduce the issue?
1. Run `hasura console --endpoint 'https://my.server'` against server that has HASURA_GRAPHQL_ENABLE_CONSOLE=false
2. check from browser devtools that it tries to load assets still from the actual server
Contributor guide
Research direction
Run `hasura console --endpoint 'https://my.server'` against a server with the console disabled and inspect the browser's asset requests. Trace how the console command handles `--use-server-assets` and resolves asset locations; done means the local console loads without requesting static assets from the remote server, including when the flag is explicitly false.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100