hasura / hasura/graphql-engine

False success message during v1 -> v2 upgrade

Open
#7,690 0 comments 0 reactions 0 assignees View on GitHub
c/cli k/bug t/product-platform
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

### Version Information

Server Version: 1.3.2 -> 2.0.9
CLI Version (for CLI related issue): 2.0.9

### Environment

OSS

### What is the expected behaviour?

Hasura should output errors or issues when they occur during migrations and metadata application

### What is the current behaviour?

Hasura cli-migrations-v3 image incorrectly stated that metadata was applied and reloaded successfully, when in reality the sql statements hit statement timeout and did not complete.

### How to reproduce the issue?

1. Run v2.0.9 cli-migrations-v3 image against a db that contains hasura 1.3.2 metadata, set the statement timeout low and see if it logs an error when it reaches statement timeout

### Screenshots or Screencast

cli-migrations-v3 image logs:
![cli-migrations-v3 image logs](https://user-images.githubusercontent.com/37592841/137539976-0cdc0166-0211-4d8a-a4d9-36af4c94e189.png)
Note the "error" logs shown above are benign requests similar to the ones in this issue [https://github.com/hasura/graphql-engine/issues/3734](https://github.com/hasura/graphql-engine/issues/3734)

Postgres Logs:
![Postgres Logs](https://user-images.githubusercontent.com/37592841/137539969-1f5a1c23-4ce6-4d0e-afe1-2837a1ac2439.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.