hasura / hasura/graphql-engine

Allow database config to be set via env var

Open
#7,037 3 comments 9 reactions 0 assignees View on GitHub
c/server
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

Similar to how database connection string can be set with `from_env: HASURA_GRAPHQL_DATABASE_URL` in `databases.yaml`, we should be able to set

```yaml
max_connections:
from_env: HASURA_GRAPHQL_PG_CONNECTIONS
```

Contributor guide

Open the contributing guide

Research direction

Start with the database configuration described in databases.yaml and trace how the existing from_env setting for HASURA_GRAPHQL_DATABASE_URL is handled. Extend the same configuration path for max_connections and HASURA_GRAPHQL_PG_CONNECTIONS; done means the YAML form is accepted and sets the PostgreSQL connection limit from the environment variable.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.