hasura / hasura/graphql-engine

Export Data CSV fails when field contains a # character

Open
#6,843 0 comments 1 reaction 0 assignees View on GitHub
c/console
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

While exporting some data via the Export Data CSV feature, I've noticed incomplete files being generated. After doing some more testing, I've found out the writing of the file would end prematurely exactly at the point where a `#` character would be found in the field that was being written, e.g. a table containing:
```
column_a,column_b,column_c
1,blah blah,blah
2,blah #blah,blah
3,blah,blah blah
```
will produce a file like:
```
column_a,column_b
1,blah blah blah
2,blah
```
Please note that the next column and any other possible record would be skipped entirely.

Contributor guide

Open the contributing guide

Research direction

Start at the Export Data CSV entry point and reproduce the failure with a field containing a # character. Verify that the generated CSV preserves the remaining columns and records after the character, including the example rows shown in the issue.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.