hasura / hasura/graphql-engine

Saving edited comment about table don't work by Enter

Open
#6,704 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

Saving edited comment about table don't work by Enter.
For example, for editing table name it's work.

With Tab, focus on buttons Save or Cancel also dont'work.

Bacause of it, changing table comment become unaccessible from keyboard. Thats not cool.

Please, fix this small bug.
Or tell us where to see this code.

![image](https://user-images.githubusercontent.com/14993551/112221953-ad74f280-8c5a-11eb-9b57-614e0aecf5f5.png)

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by locating the table comment editor in the frontend and reproduce editing a table comment with Enter and Tab; done means Enter saves the comment and Tab reaches the Save and Cancel controls.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.