hasura / hasura/graphql-engine

Please do not suggest insecure k8s practices.

Open
#6,689 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

https://github.com/hasura/graphql-engine/blob/master/docs/graphql/core/deployment/deployment-guides/kubernetes.rst#step-2-set-the-postgres-database-url

I don't know much about k8s, but I do know for darn certain that 1) your postgres should *always* be secured and 2) you should NEVER store your pg login in a deployment.yml file. Luckily k8s has a secret store that allows you to store sensitive data like postgres passwords.

Please upgrade the docs as you are promoting insecurity by default.

Cheers!

Contributor guide

Open the contributing guide

Research direction

Start with docs/graphql/core/deployment/deployment-guides/kubernetes.rst at “Step 2: Set the Postgres Database URL.” Review how the deployment.yml example handles the Postgres login, then update the guide to use Kubernetes Secrets for sensitive credentials. Done means the default instructions no longer place the login directly in deployment.yml and clearly explain the secure approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, postgres
Domain
databases, documentation, security
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.