hasura / hasura/graphql-engine

Unhelpful error for envoking CLI when offline or in poor connectivity

Open
#10,333 0 comments 0 reactions 0 assignees View on GitHub
c/v3-cli ddnbugbounty-2024 k/v3-bug
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

### Component

Impacts CLI

### What is the current behaviour?

When running a DDN command (in my case, ddn connector link update) it throws a scary-looking warn with an error message about not being able to auto-update.

`WRN Auto-update failed, run 'ddn update-cli' to update manually error="Command: check update: get latest version: update check request: Get \"https://graphql-engine-cdn.hasura.io/ddn/cli/v3/latest.json\": dial tcp [2606:4700::6812:67a]:443: connect: bad file descriptor"`

### What is the expected behaviour?
1. The CLI should not attempt to auto-update, rather, inform if there is an update (I assume this is the behaviour but the message looks different)
2. Display a message about not being able to connect to the server if that's the issue

### How to reproduce the issue?

1. Follow the DDN getting started up to the update connector-link steps.
3. Go offline.
4. Run the connector link update

### Keywords

DX, CLI, OFFLINE-FIRST

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with `ddn connector link update` while offline and inspect the auto-update warning described in the report. Trace the CLI's update-check and connectivity error handling; done means offline commands avoid a scary auto-update warning and clearly report connectivity problems when appropriate.

Written by the indexing model from the issue text.

Assessment

Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.