hasura / hasura/graphql-engine

Hasura auth webhook spankind of SERVER

Open
#10,241 1 comment 0 reactions 0 assignees View on GitHub
k/enhancement observability v2
Dominant language
TypeScript
Stars
32.1k
Forks
3k
PR merge metrics
PR metrics pending

Description

The first call to the webhook, POST/authenticate, has a SpanKind of INTERNAL:

Since it is the first call in a service that appears to be a synchronous request-response flow, the SpanKind should be SERVER. (OTel docs for reference -- SpanKind)
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind

Request is, when Hasura emits spans for this particular call, can it have a SpanKind of SERVER please?

Contributor guide

Open the contributing guide

Research direction

Start by locating the code that emits Hasura's auth webhook span for POST /authenticate and compare its current INTERNAL kind with the OpenTelemetry SpanKind reference linked in the issue. Done means this call emits a SERVER span and the behavior is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.