haskell / haskell/vscode-haskell

"Haskell: Restart LSP Server" command doesn't take changed extension settings into account

Open
#331 3 comments 0 reactions 0 assignees View on GitHub
type: bug
Dominant language
TypeScript
Stars
597
Forks
98
PR merge metrics
No merged PRs in 30d

Description

When I change extension settings in vscode and then run "Haskell: Restart LSP Server" within vscode, the changed extension settings are not taken into account - it's still running haskell-language-server with the same flags as when I started vscode.

Steps to reproduce:
In extension settings change "Haskell: Log File" from the default value (no value) to some valid path on your filesystem.
Push Ctrl+Shift+P and select "Haskell: Restart LSP Server"

Actual: the server is restarted, but there's no logging to my file of choice. I have to to actually restart vscode itself for this setting to have and effect (to see some logs in the logging file). It works the same with other settings changes, e.g. when I change "Haskell > Trace Server" from the default (off) to "messages" and restart the lsp from within vscode, it again doesn't reflect the changes - I need to restart vscode itself for this to have an effect.

Expected: restarting HLS from vscode should use the currently selected extension settings.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.