haskell / haskell/lsp

Get rid of 'CustomMethod'

Open
#592 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
423
Forks
105
PR merge metrics
No merged PRs in 30d

Description

`CustomMethod` is a bit of a hack to squeeze in an open set of additional methods into our otherwise closed set of methods. It adds a lot of difficulty for this reason: it's not typed in the same way, it can be used as anything, and it generally prevents us from doing anything that relies on knowing all the methods.

I think it would be better to rather also expose an _untyped_ interface to the JSONRPC server. That is, be able to say something like:
```
addRequestHandler SMethod_TextDocumentCompletion $ \typedParams -> ...
Untyped.addRequestHandler "myMethod" $ \untypedParams -> ...
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.