haskell / haskell/haskell-language-server

Bug in hls-cabal-plugin

Open
#5,079 1 comment 0 reactions 1 assignee Claimed by @Aster89 View on GitHub
component: hls-cabal-plugin type: bug
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
3d 21h
Merged PRs (30d)
13

Description

Right now I don't have thorough repro steps, hence I'm assigning to myself to remember coming back to it soon, but here's what I recall (but hopefully somebody will pick this before):

- I just started playing with https://github.com/haskell/haskell-language-server/issues/5077#issuecomment-5571290270, so I was editing https://github.com/alanz/ghc-exactprint/blob/master/src/Language/Haskell/GHC/ExactPrint/Transform.hs
- I pasted the whole list of `import`s from https://github.com/Aster89/haskell-language-server/blob/master/plugins/hls-case-split-plugin/src/Ide/Plugin/CaseSplit.hs and also a good chunk of the rest of the file,
- somewhere in that process, I started going through the `import` list, deleting some from HLS, and triggering "Add dependency" for things like `import Control.Lens`, `import Control.Monad.Trans.Except`, etc.

Then I realized this had cause the following changes to the cabal file:
```diff
- build-depends: base >=4.22 && <4.23
+ build-depends: text ^>=2.1.4
+ , extra ^>=1.8.1>=0.6.1.2
+ , extra ^>=1.8.1
+ , extra ^>=1.8.1
+ , base >=4.22 && <4.23
```

which breaks it.

@fendor said the breakage might have happened with https://github.com/haskell/haskell-language-server/pull/4360, if I understood his comment.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.