haskell / haskell/haskell-language-server

Remove Unconditional time out wait for diagnostic. See `expectNoMoreDiagnostics`

Open
#4,300 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
2d 19h
Merged PRs (30d)
11

Description

It it not an easy job to remove this one. There are multiple states we need to monitor to wait for hls to settle.
After discussion with @michaelpj , we can replace the `expectNoMoreDiagnostics`'s time out with following:

* restartQueue empty
* actionQueue empty
* sessionLoader Queue empty
* rebouncer done
* hls-graph database all running is done

What we need to do:

* [x] #4301
* [ ] #4309
* [ ] implement `rebouncer` done utility.
* [ ] refactor the test util to make use of the above.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.