haskell / haskell/haskell-language-server

Consider using a typed path library

Open
#4,277 2 comments 0 reactions 0 assignees View on GitHub
Hackathon type: enhancement
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
2d 19h
Merged PRs (30d)
11

Description

## Is your enhancement request related to a problem? Please describe.

Making paths absolute can be a bit tricky for us, since it's somewhat unclear where HLS is _supposed_ to be running, and hence what relative paths are supposed to be relative _to_.

But at the moment we don't even really know the scope of the problem. Hopefully, most of the time we are dealing with absolute paths, but we have various random places where we make things absolute. It would make things a lot clearer if this was tracked in the types.

## Describe the solution you'd like

Use one of the typed path libraries for file paths. We might also need to adjust our `NormalizedFilePath` and `NormalizedUri` types to track whether they are relative or absolute, but ideally we would use the same mechanics there as whatever typed path library we use.

## Describe alternatives you've considered

Roll our own typed path library. This might be worth it if it's not much code.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.